Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: publish certificate health #43

Merged
merged 1 commit into from
Dec 7, 2022
Merged

Conversation

tenthirtyam
Copy link
Contributor

In order to have a good experience with our community, we recommend that you read the contributing guidelines for making a pull request.

Summary of Pull Request

Updates Publish-CertificateHealth to correctly retrieve the certificate health - the function now aligns more closely with the format used in other functions in the module.

Note

There is some technical debt to condense } else { and unify functions to use similar object naming. (e.g., jsonInputData vs inputData;

Signed-off-by: Ryan Johnson johnsonryan@vmware.com

Type of Pull Request

  • This is a bug fix.
  • This is an enhancement or feature.
  • This is a code style / formatting update.
  • This is a documentation update.
  • This is a refactoring update.
  • This is a chore update
  • This is something else.
    Please describe:

Related to Existing Issues

Resolves #38

Test and Documentation Coverage

  • Tests have been completed (for bug fixes / features).
  • Documentation has been added / updated (for bug fixes / features).

Standard Testbed: v4.5.0 馃帀

image

Scale Testbed: v4.4.1 馃殌

image

Breaking Changes?

  • Yes, there are breaking changes.
  • No, there are no breaking changes.

Updates `Publish-CertificateHealth` to correctly retrieve the certificate health.

Resolves #38

Signed-off-by: Ryan Johnson <johnsonryan@vmware.com>
@tenthirtyam tenthirtyam added bug Bug report/health Health Report labels Dec 7, 2022
@tenthirtyam tenthirtyam added this to the v1.0.5 milestone Dec 7, 2022
@tenthirtyam tenthirtyam requested a review from a team as a code owner December 7, 2022 01:50
@tenthirtyam tenthirtyam self-assigned this Dec 7, 2022
Copy link
Contributor

@GaryJBlake GaryJBlake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GaryJBlake GaryJBlake merged commit 34a88e5 into main Dec 7, 2022
@GaryJBlake GaryJBlake deleted the fix/publish-certificate-health branch December 7, 2022 10:06
@github-actions
Copy link

github-actions bot commented Jan 7, 2023

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Bug report/health Health Report
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error: Certificate Health Status has blank rows in the Health Report
2 participants